Skip to content

Add swift-asn1 and swift-certificates to update-checkout #64045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2023
Merged

Add swift-asn1 and swift-certificates to update-checkout #64045

merged 1 commit into from
Mar 4, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Mar 2, 2023

These are needed for SwiftPM registry work. We're using the main branch for now but will switch to concrete versions closer to the release.

@neonichu neonichu requested a review from shahmishal as a code owner March 2, 2023 22:55
@neonichu
Copy link
Contributor Author

neonichu commented Mar 2, 2023

@swift-ci please test

@neonichu neonichu requested a review from tomerd March 2, 2023 22:55
@neonichu
Copy link
Contributor Author

neonichu commented Mar 2, 2023

@swift-ci please smoke test

@neonichu neonichu mentioned this pull request Mar 3, 2023
Merged
@shahmishal
Copy link
Member

Useful info https://github.com/apple/swift/blob/main/docs/Branches.md?plain=1#L91

@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

apple/swift-crypto#149
apple/swift-certificates#32
swiftlang/swift-package-manager#6216
@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

apple/swift-crypto#149
apple/swift-certificates#32
swiftlang/swift-package-manager#6216
@swift-ci please test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

apple/swift-crypto#149
swiftlang/swift-package-manager#6216
@swift-ci please test

@neonichu
Add swift-asn1 and swift-certificates to update-checkout
c4e50fe 
Also update swift-crypto to 2.3.0
These are needed for SwiftPM registry work. We're using the `main` branch for now but will switch to concrete versions closer to the release.
@neonichu neonichu force-pushed the add-certs-asn1-to-checkouts branch from 1b09852 to c4e50fe Compare March 3, 2023 18:17
@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

swiftlang/swift-package-manager#6216
@swift-ci please test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

swiftlang/swift-package-manager#6216
@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023 •
edited
Loading

Some random Swift tests failed on the macOS job

Failed Tests (2):
  Swift(iphonesimulator-x86_64) :: diagnostics/pretty-printed-diagnostics.swift
  Swift(iphonesimulator-x86_64) :: diagnostics/pretty-printed-source-loc-directive-diags.swift

This also means we did not even get to building SwiftPM. The Linux job passed and build the new libraries as expected.

@neonichu
Copy link
Contributor Author

neonichu commented Mar 3, 2023

swiftlang/swift-package-manager#6216
@swift-ci please test macOS

@neonichu neonichu mentioned this pull request Mar 3, 2023
Merged
@shahmishal shahmishal merged commit 1d03053 into swiftlang:main Mar 4, 2023
@neonichu neonichu deleted the add-certs-asn1-to-checkouts branch March 4, 2023 19:08
@finagolfin
Copy link
Member

@neonichu, just noticed this when building the latest trunk snapshot from source: do you plan on switching to concrete versions before the 5.9 branch? Because these repos don't have any snapshot tagging set up yet and will just check out random commits from the main branch until then.

That's fine for toolchain developers who just build latest trunk, but causes problems for those who want more stable builds and use the snapshot tags for that.

@neonichu
Copy link
Contributor Author

neonichu commented Mar 8, 2023

@buttaface yah, the plan is to switch to a concrete version, like we do for e.g. swift-crypto, once the libraries are mature enough (sometime before the 5.9 branch date).

@yim-lee
Copy link
Contributor

yim-lee commented Mar 10, 2023 •
edited
Loading

pinning them in #64285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal left review comments

@yim-lee yim-lee yim-lee left review comments

@tomerd tomerd tomerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neonichu @shahmishal @finagolfin @yim-lee @tomerd